Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Schema impl for std::string::String with the use-std feature and for alloc::string::String with alloc #76

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

zRedShift
Copy link
Contributor

Hi, we found a use for Schema in an std context, and the non-heapless String impl was missing.

Would you be okay with adding this impl?

BTW, I find that that this experimental feature is useful for serde in general, not just for postcard use.

@netlify
Copy link

netlify bot commented Sep 14, 2022

Deploy Preview for cute-starship-2d9c9b canceled.

Name Link
🔨 Latest commit aa41cf3
🔍 Latest deploy log https://app.netlify.com/sites/cute-starship-2d9c9b/deploys/6321ca5388e47d00085d1462

Copy link
Owner

@jamesmunns jamesmunns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@jamesmunns jamesmunns merged commit 3e15a40 into jamesmunns:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants