Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge and CSV parser #42

Merged
merged 11 commits into from
Dec 2, 2022
Merged

Edge and CSV parser #42

merged 11 commits into from
Dec 2, 2022

Conversation

stuartjash
Copy link
Contributor

@stuartjash stuartjash commented Nov 15, 2022

  • added support for Edge browser (pretty much identical to Chrome)
  • fixed typo in browsers.txt file
  • instead of using computer name for aftermath directory name, using serial number instead. This is much more consistent. if serial number comes back as null, use the device name
  • removed timestamp from file name to remove clutter and added a 'started collection' log line in the aftermath.log
  • Wrote our own csv parser as the SwiftCSV package was throwing errors and they were unable to be handled gracefully. This change required rewrites to much of the analysis section. This should address Issue quotation(message: "Can\'t have non-quote here: F") #38
  • added macOS 11 compatibility for collection only. Analysis still requires macOS 12 or greater. Per issue Does not run on macOS 11 #41
  • updated program entry to exit if not root
  • added shields to readme for readability

@stuartjash stuartjash changed the title Edge and minor updates Edge and CSV parser Nov 15, 2022
@jbradley89 jbradley89 merged commit 623aa77 into jamf:main Dec 2, 2022
@stuartjash stuartjash deleted the stuartjash_edge branch June 2, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants