fix: use native ScanType from driver and enhance RowBuffer to understand more types #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the go mysql driver provides a very good mapping of database types to go types by doing
reflect.New(tp.ScanType()).Interface()
directly instead of manually mapping all integers tosql.NullInt64
, strings tosql.NullString
, etc. withreflectColumnType()
It seems the reason the
ColumnType
was being interpreted differently was to account for mocking VARCHAR columns that were expected to have rows with NULL values that could not be scanned to a simplestring
, the fix was to change the unit tests to have thesampleValue
be asql.NullString{}
instead of a simplestring
.This allows database connections that have
ParseTime = true
to correctly dumpDATETIME
columns.Also wrapped
SET NAMES
andSET character_set_client
with mysql version comments like mysqldump does.