add comments to indicate dummy nature of 'Owner' result fields

jamhall · Mar 5, 2021 · f0d087d · f0d087d
1 parent e91f76d
commit f0d087d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/lib/controllers/bucket.js b/lib/controllers/bucket.js
@@ -269,6 +269,7 @@ exports.getBucket = async function getBucket(ctx) {
           Size: object.size,
           Owner: options.fetchOwner
             ? {
+                // we assume the objects are owned by the fetching user since we don't store owner metadata with objects
                 ID: ctx.state.account.id,
                 DisplayName: ctx.state.account.displayName,
               }

diff --git a/lib/controllers/object.js b/lib/controllers/object.js
@@ -208,6 +208,7 @@ exports.getObjectAcl = async function getObjectAcl(ctx) {
     AccessControlPolicy: {
       '@': { xmlns: 'http://doc.s3.amazonaws.com/2006-03-01/' },
       Owner: {
+        // we assume the objects are owned by the fetching user since we don't store owner metadata with objects
         ID: ctx.state.account.id,
         DisplayName: ctx.state.account.displayName,
       },

diff --git a/lib/controllers/service.js b/lib/controllers/service.js
@@ -19,6 +19,7 @@ exports.getService = async function getService(ctx) {
     ListAllMyBucketsResult: {
       '@': { xmlns: 'http://doc.s3.amazonaws.com/2006-03-01/' },
       Owner: {
+        // we provide dummy values here because we don't store any metadata with buckets
         ID: 'BUCKET_OWNER_ID',
         DisplayName: 'BUCKET_OWNER_DISPLAY_NAME',
       },