Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed fast-xml-parser version and implementation #813

Closed

Conversation

miguel-padilla92
Copy link

No description provided.

@zachrog
Copy link

zachrog commented Jun 23, 2023

Nice job. Would love to get this merged in ASAP to fix the high security vulnerability that appears when using S3rver as a dependency.

@j0k3r
Copy link

j0k3r commented Jun 24, 2023

After checking it, there are really more stuff to be done before that PR will be ok to merge.

I've forked the project to fix them all.

20minutes#1

@miguel-padilla92
Copy link
Author

After checking it, there are really more stuff to be done before that PR will be ok to merge.

I've forked the project to fix them all.

20minutes#1

I saw the PR you made, will you do a merge so I can close this one?

@j0k3r
Copy link

j0k3r commented Jun 28, 2023

I'm not sure @jamhall is actively maintaining the lib, so we'll keep using our fork instead of providing a PR here unless @jamhall wants to integrate it.

@zachrog
Copy link

zachrog commented Aug 4, 2023

I'm not sure @jamhall is actively maintaining the lib, so we'll keep using our fork instead of providing a PR here unless @jamhall wants to integrate it.

Thank you @j0k3r . I think you are correct. We appreciate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants