Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version (1.0.9) fails on IE10 and below #73

Open
ccsantos23 opened this issue Dec 2, 2014 · 3 comments
Open

Latest version (1.0.9) fails on IE10 and below #73

ccsantos23 opened this issue Dec 2, 2014 · 3 comments

Comments

@ccsantos23
Copy link

Demo site works (it's using v1.0.3), but the following test for IE in v1.0.9 fails:

if ( /msie/.test(navigator.userAgent.toLowerCase()) && parseInt(navigator.appVersion,10) <= 6)

because parseInt(navigator.appVersion,10) does not return the version number.
Check out the discussion here http://stackoverflow.com/a/15983064 (their test for IE version won't work for IE11, but that's fine because your plugin only needed to test for older IE).

p.s. Thanks for a great plugin.

@dmasterman
Copy link

Please take me off your list
Thanks

On Dec 2, 2014, at 12:05 AM, Carmela Santos notifications@github.com wrote:

Demo site works (it's using v1.0.3), but the following test for IE in v1.0.9 fails:

if ( /msie/.test(navigator.userAgent.toLowerCase()) && parseInt(navigator.appVersion,10) <= 6)

because parseInt(navigator.appVersion,10) does not return the version number.
Check out the discussion here http://stackoverflow.com/a/15983064 http://stackoverflow.com/a/15983064 (their test for IE version won't work for IE11, but that's fine because your plugin only needed to test for older IE).

p.s. Thanks for a great plugin.


Reply to this email directly or view it on GitHub #73.

@ccsantos23
Copy link
Author

Ack sorry, I'm new to Github. Which list?

@abmultimedia
Copy link

I'm seeing this issue as well.

brandoncarl added a commit to brandoncarl/country-selector that referenced this issue Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants