Skip to content

Commit

Permalink
Merge pull request #72 from jamis/mberlanda/restore-2.2-support
Browse files Browse the repository at this point in the history
Restore ruby 2.2 support
  • Loading branch information
mberlanda authored Feb 7, 2021
2 parents 27e0e28 + b593f79 commit 0c7e9b3
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 7 deletions.
4 changes: 4 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ matrix:
allow_failures:
- rvm: ruby-head
include:
- rvm: 2.2
gemfile: gemfiles/rails_3.gemfile
- rvm: 2.2
gemfile: gemfiles/rails_4.gemfile
- rvm: 2.3
gemfile: gemfiles/rails_3.gemfile
- rvm: 2.3
Expand Down
5 changes: 5 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
appraise "rails-3" do
gem "rails", "~> 3"
gem "sqlite3", "~> 1.3.6"
gem "test-unit", "~> 3.0"
end

appraise "rails-4" do
gem "rails", "~> 4"
gem "sqlite3", "~> 1.3.6"
end

appraise "rails-5" do
gem "rails", "~> 5"
gem "sqlite3"
end

appraise "rails-6" do
gem "rails", "~> 6"
gem "sqlite3"
end
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,17 +198,18 @@ worker.result_sets
> This gem represents the state of art for rails version < 6 and it is still open to
> further developments for more recent versions.
The current CI prevents regressions on the folling versions:
The current CI prevents regressions on the following versions:

ruby / rails | `~>3` | `~>4` | `~>5` | `~>6`
:-----------:|-------|-------|-------|------
2.2 | yes | yes | no | no
2.3 | yes | yes | yes | no
2.4 | no | yes | yes | no
2.5 | no | no | yes | yes
2.6 | no | no | yes | yes
2.7 | no | no | yes | yes

> Any extending to the test suite to validate other db adapter than sqlite is welcome.
> Any extension to the test suite to validate other db adapter than sqlite is welcome.
## License

Expand Down
4 changes: 0 additions & 4 deletions bulk_insert.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ Gem::Specification.new do |s|
s.description = "Faster inserts! Insert N records in a single statement."
s.license = "MIT"

# ruby 2.2 reached EOL in 2018
# https://www.ruby-lang.org/en/news/2018/06/20/support-of-ruby-2-2-has-ended/
s.required_ruby_version = '>= 2.3.0'

s.files = Dir["{app,config,db,lib}/**/*", "MIT-LICENSE", "Rakefile", "README.md"]
s.test_files = Dir["test/**/*"]

Expand Down
2 changes: 1 addition & 1 deletion gemfiles/rails_4.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

source "https://rubygems.org"

gem "minitest"
gem "rails", "~> 4"
# https://github.com/rails/rails/blob/4-2-stable/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb
gem "sqlite3", "~> 1.3.6"

gemspec path: "../"
1 change: 1 addition & 0 deletions gemfiles/rails_5.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest"
gem "rails", "~> 5"
gem "sqlite3"

Expand Down
1 change: 1 addition & 0 deletions gemfiles/rails_6.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

source "https://rubygems.org"

gem "minitest"
gem "rails", "~> 6"
gem "sqlite3"

Expand Down

0 comments on commit 0c7e9b3

Please sign in to comment.