-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Double-quoting column names in ON CONFLICT statement (PostgreSQL) #48
base: master
Are you sure you want to change the base?
Double-quoting column names in ON CONFLICT statement (PostgreSQL) #48
Conversation
Last Job in Check failed before starting test, freeze on line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steverovsky @ziggy1 Thank you very much for the time taken to write and review this PR.
The current test matrix is actually broken and it has been fixed in #51.
Once this would be merged, you may be able to rebase and get your tests working.
Would it be possible to provide an example from the psql
console of the double-quoting issue on the ON CONFLICT
statement?
As per today, the output of this gem is not tested yet against real datastores (that's my bad since I never finished #37 🤦♂ )
Thanks again for the time spent on this pr and do not hesitate to request my review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @steverovsky @ziggy1 I updated the test matrix to validate any future change. Could you please rebase on the master branch and submit the PR again? Thanks
PostgreSQL supports uppercase in column names, but
Worker
class has a bug withON CONFLICT
statement.Case: When column name in uppercase or contains uppercase letter, we get error like
excluded.title does not exist
(original column name isTitle
).Reason: All identifiers (including column names) that are not double-quoted are folded to lower case in PostgreSQL.
Solution: Column names must to be double-quoted.