Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of multiple nav bar buttons instead of just one left an one right #582

Closed
wants to merge 2 commits into from

Conversation

markrickert
Copy link
Contributor

set_nav_bar_buttons :right, [{
  custom_view: my_custom_view_button
},{
  title: "Tasks",
  image: UIImage.imageNamed("whatever"),
  action: nil
}]

@ryanlntn
Copy link
Contributor

Cool! 👍 Thoughts on accepting a hash instead so you can set both sides at once?

@markrickert
Copy link
Contributor Author

well, we have helper methods for individual sides like set_right_nav_bar_button {title: 'whatever'}. I guess we could do that as well... but you can't currently set left and right at the same time with the current methods in Promotion, so i'm not sure we'd want to add them.

@ryanlntn
Copy link
Contributor

@markrickert Right. I was thinking it'd be similar to how we do open_menu in ProMotion-menu. Not sure how useful it'd be though.

@jamonholmgren
Copy link
Owner

This is cool!

@markrickert
Copy link
Contributor Author

@jamonholmgren, any thoughts on adding left and right convenience methods?

@jamonholmgren
Copy link
Owner

@markrickert Sorry, just saw your question!

I think it's fine as-is. Will merge at next minor update.

@ryanlntn
Copy link
Contributor

Staged for release on the version-2.3 branch.

@anguskwan
Copy link

it's cool!

@markrickert markrickert deleted the multiple_nav_bar_buttons branch February 4, 2015 19:30
@markrickert markrickert restored the multiple_nav_bar_buttons branch February 4, 2015 19:30
@jamonholmgren
Copy link
Owner

@markrickert , just FYI, we're moving to ReadTheDocs and including documentation in the pull request (./docs folder) in future pull requests.

@jamonholmgren
Copy link
Owner

@kevinvangelder Can you include Mark's documentation for this PR in the #622 PR?

@markrickert markrickert deleted the multiple_nav_bar_buttons branch May 12, 2015 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants