Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong cell detection problem in search_result_table of longpressable TableScreen. #596

Merged
merged 1 commit into from
Jan 16, 2015
Merged

Fix wrong cell detection problem in search_result_table of longpressable TableScreen. #596

merged 1 commit into from
Jan 16, 2015

Conversation

satoyos
Copy link
Contributor

@satoyos satoyos commented Jan 15, 2015

...e TableScreen.

@satoyos
Copy link
Contributor Author

satoyos commented Jan 15, 2015

Sorry, I'll rewrite my comment.

In my Sample App, I found a problem;

  1. Launch TableScreen App.
  2. Search.
  3. Scroll up search result,
  4. and Long-press a cell.
  5. Then, wrong cell is detected...

I think, searchResultsTableView should be used, instead of table_view, to detect gesture_point and index_path in this situation.
Is that right?

2015-01-15_longpressable_problem

@satoyos satoyos changed the title Fix wrong cell detection problem in search_result_table of longpressabl... Fix wrong cell detection problem in search_result_table of longpressable TableScreen. Jan 15, 2015
@jamonholmgren
Copy link
Owner

Good catch, @satoyos ! @markrickert , look good to you?

@markrickert
Copy link
Contributor

Yup! looks good! Another good catch!

jamonholmgren added a commit that referenced this pull request Jan 16, 2015
@jamonholmgren
Merge pull request #596 from satoyos/longpress_on_search_result
6ee5d36 
Fix wrong cell detection problem in search_result_table of longpressable TableScreen.
@jamonholmgren jamonholmgren merged commit 6ee5d36 into jamonholmgren:master Jan 16, 2015
@jamonholmgren
Copy link
Owner

Thanks @satoyos !

@satoyos
Copy link
Contributor Author

satoyos commented Jan 16, 2015

My pleasure!
I'm looking forward to next update!

@satoyos satoyos deleted the longpress_on_search_result branch January 16, 2015 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoyos @jamonholmgren @markrickert