Fixes issue with auto-detected links not opening. #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now for extternal links it specifically looks for http or https in the url scheme, thus allowing the system to handle map links, tel:, sms: and mailto:
|
👍 |
| @@ -119,13 +119,15 @@ def open_in_safari(inRequest) | |||
|
|
|||
| # UIWebViewDelegate Methods - Camelcase | |||
| def webView(inWeb, shouldStartLoadWithRequest:inRequest, navigationType:inType) | |||
There was a problem hiding this comment.
Nitpicky, but could you rename these to in_request and in_type for consistency?
There was a problem hiding this comment.
It's been like that for a long time and NOW you're complaining?!
Sheesh!
There was a problem hiding this comment.
Should have left well enough alone! lol
|
I just removed CircleCI's web hook (they're not set up for RubyMotion), by the way. |
|
Will merge when Travis finishes randomly failing for no reason. |
|
👍 ❤️ |
jamonholmgren
added a commit
that referenced
this pull request
Jan 22, 2015
…ted-links Fixes issue with auto-detected links not opening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now for external links it specifically looks for
httporhttpsin the url scheme, thus allowing the system to handlemaplinks,tel:,sms:,itmsandmailto:(and whatever else that's not a simple web link to be opened in safari or google chrome.