Custom Search For TableScreen

[sxross]

This enables TableScreen to be backward compatible if the user wants to use default search on title or search_text, but allows custom search to be specified. E.g.:

class MySearchable < PM::TableScreen
  searchable placeholder: "Search events", with: -> (cell, search_string) {
    return cell[:properties][:event_name].downcase.strip.include?(search_string.downcase.strip)
  }
end

For those wanting code that does not resist refactoring quite so much, you can specify a method:

class MySearchable < PM::TableScreen
  searchable placeholder: "Search events", with: :search_method

  # other stuff
  def search_method
    return cell[:properties][:event_name].downcase.strip.include?(search_string.downcase.strip)
  end
  }
end

Real world examples would probably be more complex.

[jamonholmgren]

This is awesome.

One more thing. We're currently working on the version-2.3 branch. Could you close this PR and bring your branch up to date with version-2.3 and do a new PR into that branch? I may not merge it in time for 2.3 but definitely for 2.4.

With that change, we're also including documentation (via the ./docs folder) in future PRs, so update the markdown documentation there.

Sorry to make you jump through so many hoops. You'll be a card-carrying ProMotion contributor of note after this one. ;)

[sxross]

I've updated sxross/ProMotion -b search_with to the version-2.3 code. Feel free to pull this whenever ready. I guess my git-foo returned (to some extent :).

[jamonholmgren]

Moved to #641.