Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a on_continue_user_activity delegate method #773

Merged

Conversation

felixclack
Copy link
Contributor

In iOS 9, there is a delegate method to handle opening the app from
notifications and Handoff from other devices.

This implements support for an on_continue_user_activity method that
gets triggered when the app is opened with an activity.

@jamonholmgren
Copy link
Owner

Looks great @felixclack ! Can you check on the failing Travis build? (I don't have time today)

@felixclack felixclack force-pushed the continue_user_activity branch 3 times, most recently from fd6fe3e to 30029d5 Compare February 13, 2016 09:59
In iOS 9, there is a delegate method to handle opening the app from
notifications and Handoff from other devices.

This implements support for an `on_continue_user_activity` method that
gets triggered when the app is opened with an activity.
@felixclack
Copy link
Contributor Author

Looks like it may have been an Xcode issue. When I target the latest, non-beta version of Xcode (currently 7.2) the error disappears.

Are you happy with me introducing this into the Travis setup?

@felixclack
Copy link
Contributor Author

@jamonholmgren How's this looking now?

@jamonholmgren
Copy link
Owner

Sorry for missing this @felixclack ! LGTM. :)

jamonholmgren added a commit that referenced this pull request Feb 22, 2016
Add a `on_continue_user_activity` delegate method
@jamonholmgren jamonholmgren merged commit 6c93f5b into jamonholmgren:master Feb 22, 2016
@jamonholmgren
Copy link
Owner

Will release a new version next week.

@felixclack
Copy link
Contributor Author

Awesome. Thanks.

kevinvangelder pushed a commit that referenced this pull request Mar 8, 2016
323 specifications (659 requirements), 0 failures, 0 errors
kevinvangelder pushed a commit that referenced this pull request Mar 8, 2016
Possible fix for #773. My app no longer crashes.
@jamonholmgren
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants