Fix iOS10 crashing when image picker is called #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When presenting a `UIImagePickerController` the app would crash because `visibleViewController` was `nil` when being called by the navigation controller. The actual changes to iOS10 implementation of `visibleViewController` remains a mystery, but this adds a sensible fallback in the case that it's set to nil. Fixes #795.
|
Ah the if statement 😢 |
|
👍 |
|
Thank you! Use from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When presenting a
UIImagePickerControllerthe app would crash becausevisibleViewControllerwasnilwhen being called by the navigationcontroller.
The actual changes to iOS10 implementation of
visibleViewControllerremains a mystery, but this adds a sensible fallback in the case that
it's set to nil.
Fixes #795.