Removes all app.files_dependencies #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #810. There should probably be a larger discussion as to if/when this should be included in `master` just because this is a High-Sierrra issue. Has anyone tried it on Mojave?
|
A while back I introduced a |
|
Oh, looks like I also created a milestone and assigned some potential issues/features. https://github.com/infinitered/ProMotion/milestone/13 |
|
Is there a particular reason you want to wait till a v3 for this? I believe that this patch is necessary if you're trying to compile on anything High Sierra or newer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #810.
There should probably be a larger discussion as to if/when this should be included in
masterjust because this is a High-Sierrra issue. Has anyone tried it on Mojave?