Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove live reloading functionality. #818

Merged
merged 1 commit into from
Oct 10, 2019

Conversation

markrickert
Copy link
Contributor

Sorry @jamonholmgren 😢

Closes #797

Copy link
Collaborator

@andrewhavens andrewhavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢 Probably a good idea.

@andrewhavens
Copy link
Collaborator

@markrickert Do you know if RedPotion will break if this is removed?

@andrewhavens andrewhavens added this to the 3.0.0 milestone Oct 10, 2019
@markrickert
Copy link
Contributor Author

Red potion did not break.

  1. Clone redpotion
  2. add entry to gemfile to point at new branch
  3. bundle
  4. bundle exec rake spec - all tests pass
  5. bundle exec rake - app runs fine
  6. type RubyMotionQuery::RMQ.debugging = true into REPL
  7. (main)> live => "Live reloading of RMQ stylesheets is now on."
  8. (main)> live(1.0, true)
path_query: /Users/markrickert/Documents/redpotion/app/stylesheets/**/*.rb
/Users/markrickert/Documents/redpotion/app/stylesheets/home_screen_stylesheet.rb
~/Documents/redpotion/app/stylesheets/collection_screen_stylesheet.rb
~/Documents/redpotion/app/stylesheets/tasks_screen_stylesheet.rb
~/Documents/redpotion/app/stylesheets/contributor_screen_stylesheet.rb
~/Documents/redpotion/app/stylesheets/metal_table_screen_stylesheet.rb
~/Documents/redpotion/app/stylesheets/collection_cell_stylesheet.rb
~/Documents/redpotion/app/stylesheets/example_controller_stylesheet.rb
~/Documents/redpotion/app/stylesheets/application_stylesheet.rb
=> "Live reloading of RMQ stylesheets is now on."

Screen Shot 2019-10-10 at 2 08 32 PM

Screen Shot 2019-10-10 at 2 08 12 PM

bundle exec rake spec

121 specifications (167 requirements), 0 failures, 0 errors

@andrewhavens andrewhavens removed this from the 3.0.0 milestone Oct 10, 2019
@andrewhavens andrewhavens merged commit a7175be into master Oct 10, 2019
@markrickert markrickert deleted the sans-live-reload branch October 10, 2019 22:41
@jamonholmgren
Copy link
Owner

End of an era. That was such a cool thing when I first discovered it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'live' and 'pm_live' don't work anymore with version 4.13
3 participants