Fix a bug where our freedns name was having a capital name.

[tzachi-dar]

No description provided.

[Navid200]

If we don't merge this PR and we have capital letter in the subdomain, what will happen?
Please help me see the problem.

[tzachi-dar]

The issue is in the line
if [ ! -s /etc/letsencrypt/live/"$hostname"/cert.pem ] || [ ! -s /etc/letsencrypt/live/"$hostname"/privkey.pem ]

We are checking here that a file exists to know that we have succeeded. But this does not work since on the file name, the files are with small letters. That is letsencrypt always create the filename with small letters, and we think the file is not there and try again.

[Navid200]

Is this the line?
https://github.com/tzachi-dar/nightscout-vps/blob/c267a432b8c6336e29a3380b3e113556468cbd3c/ConfigureFreedns.sh#L192

[Navid200]

Let me test it.

[Navid200]

I created a new subdomain with a capital letter in it.
I went through phase 2.
I can see that even though it has found the ip, it keeps saying freedns failed sleeping and keeps asking me to choose between 1 and 2.

Now, let me use your new suggested file instead.

[Navid200]

Yes, with the suggested change, a new subdomain containing a capital letter works fine.

So, I see the problem and I see that your suggestions fixes it. Thanks

@jamorham Would you please have a look at this PR and if it looks OK to you, would you please merge it?