Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeDNS user ID capital letter dialog #33

Merged
merged 2 commits into from
Dec 10, 2022

Conversation

Navid200
Copy link
Collaborator

If you create a new FreeDNS account and choose a user ID that has capital letters in it, FreeDNS will not inform you and approves your account. However, your user ID will be converted to all lowercase letters.

If you attempt to log into FreeDNS with the original user ID containing capital letters, your login will be rejected.

If you log into FreeDNS, you can see your approved user ID, which is identical to the one you entered with all letters converted to lowercase.

This PR informs the user if they enter a user ID containing capital letters with the following dialog:
Screenshot 2022-11-29 191602

Thanks to @justinthomas for reporting this here: #32.

Capital letters in the FreeDNS user ID dialog
@justinthomas
Copy link

Excellent, that message would've saved me some time and will certainly help prevent someone else from the same difficulty.

@Navid200 Navid200 changed the title FreeDNS user ID caspital letter dialog FreeDNS user ID capital letter dialog Nov 30, 2022
@jamorham
Copy link
Owner

jamorham commented Dec 2, 2022

can't we just lowercase whatever they enter?

@Navid200
Copy link
Collaborator Author

Navid200 commented Dec 2, 2022

@jamorham If everything had been done correctly, by FreeDNS, they would inform a user that capital letters in the userID will be changed to lower case as soon as the user entered such in the form.
But, FreeDNS does not do that.
Instead, they change the selected accepted user ID and change it all to lower case.

We can be complicit with the FreeDNS behavior and also hide things from the user and just convert the user ID to lower case.

I suggested that we did not do that. Instead we are informing the user what has happened. That if they log into FreeDNS and pay attention, they can see that their user ID does not contain capital letters.

But, the short answer to your question is, yes, we can.

@Navid200
Copy link
Collaborator Author

Navid200 commented Dec 2, 2022

@jamorham The fact that the user has entered a user ID containing capital letters shows that the user is not aware their user ID has been changed.
Alternatively, it may just suggest that the user has made a typo and entered their user ID incorrectly.

Either way, FreeDNS changes the selected user ID by the user without clearly notifying them.
This is the email I received:
Screenshot 2022-12-02 133258

I have marked the only sign that my chosen user ID has been changed by a red enclosing rectangle. That's all. How likely is it that the user will pay attention to that? I didn't.

@jamorham jamorham merged commit a7441dc into jamorham:vps-1 Dec 10, 2022
@Navid200 Navid200 deleted the CapUserID_PR branch January 4, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants