Single quotes #53
Single quotes #53
Conversation
Adjusted dialog frames for consistency.
Single quotes
Date
Cleanup
|
This has been tested using this repo: https://github.com/Navid200/cgm-remote-monitor/tree/SingleQuotes_Test |
|
|
||
| for j in {1..1000} |
There was a problem hiding this comment.
what happened to this part?
There was a problem hiding this comment.
We're now using a dialog for the API_SECRET.
I understood that was needed when using a text prompt for asking for the API_SECRET.
Did I misunderstand?
There was a problem hiding this comment.
What happens when someone presses a lot of chars before reaching this stage. Are they being removed?
There was a problem hiding this comment.
I don't have a maximum for the number of characters anywhere in any of the dialogs.
Do we need to specify a maximum?
I can add that to the prompt asking user to enter an API_SECRET that has 12-24 characters for example.
Should I do that?
There was a problem hiding this comment.
The issue is not with the length of the API_SECRET but rather with what happens when the scripts are running and someone presses a few keys. Will this keys be part of the dialog, or are they removed automatically.
There was a problem hiding this comment.
The dialog will take all the keys as intended characters until the user presses enter. Then, all the characters enterd will be accepted as the password.
There was a problem hiding this comment.
This is where that loop is right now before this PR:
It's after the prompt asking for the password is shown on screen not before.
There was a problem hiding this comment.
This is the PR that put that loop there: #24
So, it's my fault. I put it in the wrong place.
The loops should be there when a script is running taking a very long time. Then, if the user presses a button by mistake, we need to make sure what comes next will not be broken by those keys.
But, where I have inserted the loop is wrong.
NS_Install2.sh
Outdated
| Value=$(dialog --colors --ok-label "Submit" --form " \Zr Developed by the xDrip team \Zn\n\n\n\ | ||
| Your current API_SECRET is $cs\n\n\ | ||
| You can press escape to maintain the existing one. Or, enter a new one with at least 12 characters excluding the following.\n\n\ | ||
| $ \" \\\n " 19 50 0 "API_SECRET:" 1 1 "$secr" 1 14 25 0 2>&1 1>&3) |
There was a problem hiding this comment.
when using single quotes the following are allowed: $ " \ \n the only one that is not allowed is ' it self.
There was a problem hiding this comment.
I thought Nightscout itself had difficulty with $.
Even in Heroku, I thought $ was unacceptable.
There was a problem hiding this comment.
Considering we still have systems that have " in their nsconfig, how about this for the exceptions?
$ ' "
There was a problem hiding this comment.
Should also be OK. The most important part is to also remove the ' from the text.
There was a problem hiding this comment.
I don't know what you mean by that.
|
@tzachi-dar I ran a test including \ in the API_SECRET and it failed. I only tested that once. I cannot be 100% sure that was the reason. But, I left \ in as an excluded character. I have updated the images above to reflect the updated PR. The loop is gone because where it is placed in the existing code is useless. |
This PR mainly changes the behavior of the Install Nightscosut phase 2 script.
Currently, a fresh install uses double quotes in the nsconfig file.
After this PR, single quotes will be used in a new nsconfig file.
The same script also offers the user the option to change API_SECRET. It can be used by someone who has an existing system. In that case, the existing nsconfig file may include double quotes. Therefore, some of the added code was needed to allow the existing API_SECRET to be recovered regardless of is single quotes are used on double quotes in the nsconfig file.
This is the new menu that asks for API_SECRET:
This is what you will see if what you enter has less than 12 characters.
This is what you will see if what you enter contains one of the three unacceptable special characters.
