Merge pull request ExtendRealityLtd#793 from bddckr/fix-ControllerEve…

…nts-garbage perf(ControllerEvents): don't create garbage on vector comparison
jamre · Jan 7, 2017 · f8d0ec9 · f8d0ec9
2 parents d49cebf + a491404
commit f8d0ec9
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/Assets/VRTK/Scripts/Interactions/VRTK_ControllerEvents.cs b/Assets/VRTK/Scripts/Interactions/VRTK_ControllerEvents.cs
@@ -2,6 +2,7 @@
 namespace VRTK
 {
     using UnityEngine;
+    using System;
 
     /// <summary>
     /// Event Payload
@@ -1065,8 +1066,9 @@ private void EmitAlias(ButtonAlias type, bool touchDown, float buttonPressure, r
 
         private bool Vector2ShallowEquals(Vector2 vectorA, Vector2 vectorB)
         {
-            return (vectorA.x.ToString("F" + axisFidelity) == vectorB.x.ToString("F" + axisFidelity) &&
-                    vectorA.y.ToString("F" + axisFidelity) == vectorB.y.ToString("F" + axisFidelity));
+            var distanceVector = vectorA - vectorB;
+            return Math.Round(Mathf.Abs(distanceVector.x), axisFidelity, MidpointRounding.AwayFromZero) < float.Epsilon
+                   && Math.Round(Mathf.Abs(distanceVector.y), axisFidelity, MidpointRounding.AwayFromZero) < float.Epsilon;
         }
 
         private void DisableEvents()