Refactor proxy #1627
clippy
21 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 21 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.81.0 (eeb90cda1 2024-09-04)
- cargo 1.81.0 (2dbb1af80 2024-08-20)
- clippy 0.1.81 (eeb90cd 2024-09-04)
Annotations
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 193 in plane/plane-tests/tests/common/resources/pebble.rs
github-actions / clippy
function `avoid_weird_mac_bug` is never used
warning: function `avoid_weird_mac_bug` is never used
--> plane/plane-tests/tests/common/resources/pebble.rs:193:14
|
193 | pub async fn avoid_weird_mac_bug(name: &str, scratch_dir: &Path) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
Check warning on line 79 in plane/src/proxy/cert_pair.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> plane/src/proxy/cert_pair.rs:79:38
|
79 | let key = any_supported_type(&key)?;
| ^^^^ help: change this to: `key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 189 in plane/src/proxy/proxy_server.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:186:8
|
186 | Ok(Response::builder()
| ________^
187 | | .status(status_code)
188 | | .body(simple_empty_body())
189 | | .unwrap())
| |_________________^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 103 in plane/src/proxy/proxy_server.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:103:21
|
103 | upgrade_handler.run().await.unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 94 in plane/src/proxy/proxy_server.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:94:42
|
94 | let (res, upgrade_handler) = inner.proxy_client.request(request).await.unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
Check warning on line 76 in plane/src/proxy/proxy_server.rs
github-actions / clippy
used `unwrap()` on a `Result` value
warning: used `unwrap()` on a `Result` value
--> plane/src/proxy/proxy_server.rs:76:29
|
76 | request.parts.uri = Uri::from_parts(uri_parts).unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: if this value is an `Err`, it will panic
= help: consider using `expect()` to provide a better panic message
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_used
note: the lint level is defined here
--> plane/src/lib.rs:1:9
|
1 | #![warn(clippy::unwrap_used)]
| ^^^^^^^^^^^^^^^^^^^
Check warning on line 79 in plane/src/proxy/cert_pair.rs
github-actions / clippy
this expression creates a reference which is immediately dereferenced by the compiler
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> plane/src/proxy/cert_pair.rs:79:38
|
79 | let key = any_supported_type(&key)?;
| ^^^^ help: change this to: `key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default