Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hint for buffer delay setting is inaccurate if pipewire is used #2347

Closed
jose1711 opened this issue Feb 5, 2022 · 6 comments · Fixed by #2645
Closed

Hint for buffer delay setting is inaccurate if pipewire is used #2347

jose1711 opened this issue Feb 5, 2022 · 6 comments · Fixed by #2645
Labels
bug Something isn't working
Milestone

Comments

@jose1711
Copy link
Contributor

jose1711 commented Feb 5, 2022

Describe the bug
Hint for Settings/Buffer Delay shows:
.. On Linux, use the JACK configuration tool to change the buffer size.

If a user is using Pipewire this text does not help much - changing the buffer size in - say QjackCtl has no effect. Instead jamulus needs to be started like this (for 128 samples):

PIPEWIRE_LATENCY="128/48000" jamulus

As Pipewire is being adopted by more and more Linux distribution, hint should be improved.

Operating system
Arch Linux, x86_64

@jose1711 jose1711 added the bug Something isn't working label Feb 5, 2022
@hoffie hoffie added this to the Release 3.9.0 milestone Feb 5, 2022
@hoffie
Copy link
Member

hoffie commented Feb 5, 2022

Thanks for the report. Would like to submit a PR?

Note: This will likely not make it into 3.8.2 anymore as we are in translation freeze phase (beta) already. But future versions would certainly benefit from that clarification.
Pipewire users might have the benefit that Jamulus will work out of the box for them, so they might not even know that they are using pipewire.

@jose1711
Copy link
Contributor Author

jose1711 commented Feb 5, 2022

Thanks for the report. Would like to submit a PR?

I would better pass than on to those with better level of English than me 😄

Note: This will likely not make it into 3.8.2 anymore as we are in translation freeze phase (beta) already. But future versions would certainly benefit from that clarification. Pipewire users might have the benefit that Jamulus will work out of the box for them, so they might not even know that they are using pipewire.

Yes, I can confirm that (no need to start with pw-jack or first starting qjackctl to start Jack first). Hmm.. thinking about this.. could hints be generated dynamically during the startup (why show Linux-related stuff to Windows users and vice-versa)?

@pljones
Copy link
Collaborator

pljones commented Feb 5, 2022

(why show Linux-related stuff to Windows users and vice-versa)?

The audio controls that are specific to one audio subsystem should only be being shown for that audio subsystem. JACK isn't OS-specific, of course.

However, plenty of non-OS-specific controls may have OS-specific niggles - these are generally dealt with at compile time.

@ann0see
Copy link
Member

ann0see commented Apr 23, 2022

Sorry for the maintenance noise here.

To me it seems a bit difficult to proceed here. @gilgongo @jose1711 @mulyaj do you have any other suggestion on how to move this forward? I think

On Linux, use the JACK configuration tool to change the buffer size.

Could be reworded to

If using JACK, use the JACK configuration tool to change the buffer size. Other APIs like Pipewire might need different (command line) options. Please look in their manual.

**Note: ** I 've unsubscribed from this issue to keep notifications down. If you need me, please ping me.

@jose1711
Copy link
Contributor Author

If using JACK, use the JACK configuration tool to change the buffer size. Other APIs like Pipewire might need different (command line) options. Please look in their manual.

I think this is good.

@pljones pljones linked a pull request Jun 18, 2022 that will close this issue
5 tasks
@pljones
Copy link
Collaborator

pljones commented Jun 18, 2022

Hopefully, #2645 will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants