Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer to Pipewire in buffer setting text #2645

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Refer to Pipewire in buffer setting text #2645

merged 1 commit into from
Jul 1, 2022

Conversation

gilgongo
Copy link
Member

@gilgongo gilgongo commented Jun 3, 2022 •
edited
Loading

Cover use of Pipewire in help text

CHANGELOG: Client: added instructions for setting buffers when using Pipewire

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@gilgongo gilgongo added this to the Release 3.9.0 milestone Jun 3, 2022
@pljones
Copy link
Collaborator

pljones commented Jun 4, 2022

Is the CodeQL correct?

@ann0see
Copy link
Member

ann0see commented Jun 5, 2022

@pljones Yes, CodeQl looks strange.

ann0see
ann0see reviewed Jun 5, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Not to merger: Please squash merge.

src/clientsettingsdlg.cpp Outdated Show resolved Hide resolved
@pljones pljones linked an issue Jun 18, 2022 that may be closed by this pull request
Hint for buffer delay setting is inaccurate if pipewire is used #2347
Closed
@pljones pljones mentioned this pull request Jun 18, 2022
Closed
@pljones
Copy link
Collaborator

pljones commented Jun 25, 2022

@gilgongo will this progress for 3.9.0?

@pljones
Copy link
Collaborator

pljones commented Jun 30, 2022

@ann0see @jose1711 -- are you both okay with the suggested wording above?

If so, I'll get the change made and we can get this into 3.9.0. I could do with knowing today...

@jose1711
Copy link
Contributor

@ann0see @jose1711 -- are you both okay with the suggested wording above?

If so, I'll get the change made and we can get this into 3.9.0. I could do with knowing today...

+1 from my side.

@ann0see
Copy link
Member

ann0see commented Jun 30, 2022 •
edited
Loading

Yes. Please write "QjackCtl" as on the official site https://qjackctl.sourceforge.io/

@pljones pljones force-pushed the pipewire-addition branch from a85d6d9 to f64ef34 Compare July 1, 2022 06:32
pljones
pljones reviewed Jul 1, 2022
View reviewed changes
src/clientsettingsdlg.cpp
"such as QjackCtl to adjust the buffer size. "
"Other interfaces, such as Pipewire, would require their appropriate tool being used. Please refer to the interface manual." )
.arg ( APP_NAME ) +
TOOLTIP_COM_END_TEXT;
Copy link
Collaborator

@pljones pljones Jul 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes indeed, the joy of make clang_format. Best checked with "hide whitespace".

@pljones
Copy link
Collaborator

pljones commented Jul 1, 2022

OK, as this affects translators, we need confirmation today. If I don't hear anything against it in an hour, I'll force the merge to master.

ann0see
ann0see approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only by quick glance approving it.

@pljones pljones merged commit 2de5668 into master Jul 1, 2022
@pljones pljones deleted the pipewire-addition branch July 1, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henkdegroot henkdegroot henkdegroot approved these changes

@pljones pljones pljones left review comments

@ann0see ann0see ann0see approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Hint for buffer delay setting is inaccurate if pipewire is used
5 participants
@gilgongo @pljones @ann0see @jose1711 @henkdegroot