Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network names and address cannot contain spaces #462

Closed
pljones opened this issue Jul 16, 2020 · 3 comments
Closed

Network names and address cannot contain spaces #462

pljones opened this issue Jul 16, 2020 · 3 comments
Labels
feature request Feature request

Comments

@pljones
Copy link
Collaborator

pljones commented Jul 16, 2020

As a usability improvement, any address being parsed should be checked for spaces.

Leading / trailing spaces should be trimmed. In the UI, the input field should be updated to reflect this.

Embedded spaces should prevent the value being accepted.

Reference:
https://www.facebook.com/groups/507047599870191/permalink/573265499915067/?comment_id=573296806578603&reply_comment_id=573341753240775

@corrados corrados added the feature request Feature request label Jul 16, 2020
@dingodoppelt
Copy link
Contributor

#469 Isn't it sufficient to accept every input and just remove any whitespace from it since there are no validity checks for network addresses in general?

@pljones
Copy link
Collaborator Author

pljones commented Jul 19, 2020

I think a command line passing a host name with an embedded quoted space should cause the command to be refused with an error.

That there is currently no validation is an argument for not adding validation.

@corrados
Copy link
Contributor

I have no issues with that we just remove the spaces and there is no error shown. I have merged the code from dingodoppelt and have modified it slightly. Now the custom server entry can have a space at the beginning (as written in https://www.facebook.com/groups/507047599870191/permalink/573265499915067/?comment_id=573296806578603&reply_comment_id=573341753240775) and it still works fine.
I close this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Feature request
Projects
None yet
Development

No branches or pull requests

3 participants