Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting French translation #77 #176

Merged
merged 1 commit into from
May 6, 2020
Merged

Starting French translation #77 #176

merged 1 commit into from
May 6, 2020

Conversation

trebmuh
Copy link
Member

@trebmuh trebmuh commented May 5, 2020

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@trebmuh trebmuh mentioned this pull request May 5, 2020
@corrados corrados merged commit c4a7368 into jamulussoftware:master May 6, 2020
@corrados
Copy link
Contributor

corrados commented May 6, 2020

Thank you.

@trebmuh
Copy link
Member Author

trebmuh commented May 6, 2020

@corrados thanks for the merge. If I build from master head, can I expect those strings to be translated in French in the GUI?

@corrados
Copy link
Contributor

corrados commented May 6, 2020

Since the translation is still in experimental state, you have to start Jamulus with the "--translation" command line argument to see your translations. Please give me feedback if it worked for you.

@trebmuh
Copy link
Member Author

trebmuh commented May 6, 2020

@corrados : OK, just tested and that works flawlessly.
I'll be updating the French translation on the coming days now.

@corrados
Copy link
Contributor

corrados commented May 6, 2020

Thanks for testing. Please wait some days before you continue the translation because I want to clean up some strings in the code to make the translation easier.

@trebmuh
Copy link
Member Author

trebmuh commented May 6, 2020

OK, waiting for you ping then.

@corrados BTW, are the new translated strings (*.qm) processed/calculated at build time? If so, I could check that I didn't made any mistake before making a PR next time (like the duplicate "<" on this PR).

@corrados
Copy link
Contributor

corrados commented May 6, 2020

The *.qm files are generated with the Qt "lrelease" tool. I run that tool manually before I compile the code.

@trebmuh
Copy link
Member Author

trebmuh commented May 6, 2020

OK, thanks.

@corrados
Copy link
Contributor

corrados commented May 7, 2020

Ok, clean up finished. You can continue if you like.

@trebmuh
Copy link
Member Author

trebmuh commented May 7, 2020

Nice, I'll do that ton tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants