Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FR app translation for 3.8.0 #1790

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

jujudusud
Copy link
Member

Adding more translation update in RC2 stage.

@hoffie
Copy link
Member

hoffie commented May 31, 2021

Thanks. From a quick look at the diff, this "just" cleans up the .ts file (which is good!), but does not change any visible translations, right?
If this is the case, I suggest merging it post-3.8.0 to avoid all unnecessary changes?

@hoffie hoffie added this to the Release 3.8.1 milestone May 31, 2021
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw that one word changes: "Jitter". Let's wait what the others say wrt. right time to merge.

@jujudusud
Copy link
Member Author

It is the latest translations needed by the new arrangement of the main window (jitter added and removed from parameters).
If the modifications of the jitter is merged, then the translation have also to be merged. If not, the translation will not be complete.

@hoffie hoffie modified the milestones: Release 3.8.1, Release 3.8.0 Jun 1, 2021
@hoffie
Copy link
Member

hoffie commented Jun 1, 2021

Changed milestone to 3.8.0 as this PR avoids a visible missing translation.

@hoffie hoffie requested a review from ann0see June 1, 2021 22:32
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this since I think it’s small

@ann0see ann0see merged commit bae017f into jamulussoftware:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants