-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CJamRecorder: Add currentSession pointer initialization and improve locking #1826
Conversation
Thanks for opening this PR! @pljones should have a look at this code since he wrote most of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jamulus uses an odd code style. You should apply clang format ;-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
On a high level, this looks good to me. I'm leaving the more extensive reviews for @pljones and @softins though.
There's one formatting thing to fix (you can run clang-format
on it if you have version 10 or later). I've just approved the workflows for this PR which will probably also show the relevant line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, subject to the formatting adjustments that have already been mentioned. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
OK, will upload corrected file later - after running clang-format! Thanks to all for the helpful comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested personally; code style seems to be ok. I'll let @pljones or someone else merge it.
CHANGELOG: Jam Recorder's internal locking and initiatlization code has been made more robust. |
Now running on my jam server. |
Server code tested on Windows and Ubuntu 20.04.