-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS sound support #1875
Merged
Merged
iOS sound support #1875
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a4d92b3
iOS sound + feature device switch for iOS
ngocdh f414a1c
iOS code review
ngocdh 1053b29
iOS code review
ngocdh ad4856e
iOS code review
ngocdh af76b99
iOS sound - no more malloc during sound processing
ngocdh 40221f2
Remove iOS device switch feature to keep code consistent
ngocdh be2d552
iOS switch device feature
ngocdh 2f21485
iOS sound + feature device switch for iOS
ngocdh 3e8ddc4
iOS code review
ngocdh 1949833
iOS code review
ngocdh 321cae0
iOS sound - no more malloc during sound processing
ngocdh 6848631
Remove iOS device switch feature to keep code consistent
ngocdh 85668ea
iOS switch device feature
ngocdh f91f139
Fixup rebase mistakes
softins 51bb7f7
Merge remote-tracking branch 'refs/remotes/origin/iOSsound3'
ngocdh f75fd8e
iOS sound - Typo fix and add break in loop
ngocdh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See, it's lines like this where I feel clang-format hasn't done its job right.
but I don't know Objective-C...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many spaces for Obj-C (referring to other review comment with lots of spaces)
Most places I have worked like a space between the type and the *
- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that "too many" as in "won't compile" or as in "not normal"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh it's just purely a stylistic comment - there are religious discussions about how to format Obj-C....
It makes no difference to compilation.