Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accelerator key detection #2061

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

softins
Copy link
Member

@softins softins commented Oct 7, 2021

Short description of changes

Merge base class with its derived class for dialogs (e.g. CClientDlgBase and CClientDlg)
Don't skip unfinished translations, as they still get used.

Context: Fixes an issue?

Just a tool used during the release process. It is just an aid to human checking, and not used for building the software.

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Ready to merge

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • n/a My code follows the style guide
  • n/a I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones
Copy link
Collaborator

pljones commented Oct 7, 2021

Rebase and push now the Linux build should work, please :).

Merge base class with its derived class for dialogs.
Don't skip unfinished translations, as they still get used.
@gilgongo gilgongo added this to the Release 3.9.0 milestone Oct 24, 2021
@pljones
Copy link
Collaborator

pljones commented Dec 8, 2021

Can anyone check this or should it just get merged?

Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Not sure if it is supposed to find something when started within this PR, for me it doesn't, but maybe that's simply because everything is ok. :)

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge if this is ready.

@ann0see ann0see merged commit 417ae00 into jamulussoftware:master Jan 28, 2022
hoffie added a commit to hoffie/jamulus that referenced this pull request Feb 10, 2022
hoffie added a commit to hoffie/jamulus that referenced this pull request Feb 11, 2022
hoffie added a commit to hoffie/jamulus that referenced this pull request Feb 11, 2022
ann0see added a commit that referenced this pull request Feb 11, 2022
@pljones pljones modified the milestones: Release 3.9.0, Release 3.8.2 Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants