-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accelerator key detection #2061
Conversation
Rebase and push now the Linux build should work, please :). |
Merge base class with its derived class for dialogs. Don't skip unfinished translations, as they still get used.
5b5c2a1
to
4244f63
Compare
Can anyone check this or should it just get merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Not sure if it is supposed to find something when started within this PR, for me it doesn't, but maybe that's simply because everything is ok. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge if this is ready.
ChangeLog: Add translations for 3.8.2 & #2061
Short description of changes
Merge base class with its derived class for dialogs (e.g. CClientDlgBase and CClientDlg)
Don't skip unfinished translations, as they still get used.
Context: Fixes an issue?
Just a tool used during the release process. It is just an aid to human checking, and not used for building the software.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready
What is missing until this pull request can be merged?
Ready to merge
Checklist