-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autobuild: Use Qt6 for Windows 64bit #2300
Conversation
3b51432
to
f06a7d3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
f06a7d3
to
b07803d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
b07803d
to
39d3196
Compare
39d3196
to
24dd429
Compare
1349c9d
to
26f000b
Compare
26f000b
to
6b88279
Compare
d3586bc
to
7a612ce
Compare
I've rebased this PR on current master. As #2299 has been merged, the build of this PR now succeeds as well. |
Good to know. I just wanted to add that Qt6.3.0 worked fine on my rehearsal yesterday without UI glitches. |
Installing the signed ipa on my phone works, but the app crashes. Hopefully it's not related to the Qt 6 move |
Any chance to cross-check a recent Qt5-based build? |
Does it just need conflicts resolved and review? |
In theory yes. If we decide to drop Win 7 and 8.1 it's just a small test and a click on merge away. |
7175c95
to
392c8ae
Compare
Ok. If we merge this, we need to add an auto update like on macOS. EDIT: I think we already have that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, my new Win 11 PC will need to have Qt6 on, then, for development. Once I get that far with the (re-)installs...
I believe that the scripts need to be updated with better logic to detect the difference between QT 5 and QT 6.5. Probably the regular expressions are not exact enough like in the macOS case. I still think - after testing - we can merge this. |
Ok. Windows 11 Still seems to work. I'm currently downloading a Win 10 VM to try it there too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. The Windows 10 VM seems ok too. I'll squash the two commits, merge it and then edit the CONTRIBUTING file.
32bit builds remain on 5.15.2, as Qt6 is not available there. Note: CI builds will now drop unofficial 64 Bit Windows 7 and 8.1 support. Since both are no longer supported by Microsoft, this should not be an issue. Users should update their OS or compile from source.
2b2c73c
to
d33d1e1
Compare
Dropping needs documentation as this will be part of the ChangeLog and is documented. |
Short description of changes
This PR switches the Autobuilds (and therefore: the releases!) to use Qt 6 for Windows 64bit builds.
The PR depends on the already merged PRs #2299 (initial Qt6 code compatibility) and #2328 (build logic Qt6 compatibility)
It only contains three small additional commits:
32bit builds remain on 5.15.2, as Qt6 is not available there.
Code-wise this is the smaller change. Change-wise it is the more relevant, more invasive one.
Context: Fixes an issue?
See #2299
Does this change need documentation? What needs to be documented and how?
CHANGELOG: Build: Windows 64bit releases use Qt 6.4.3 now. Jamulus will from now on only support Windows 10 and above.
Status of this Pull Request
Ready for testing
What is missing until this pull request can be merged?
I'm hoping to merge this for 3.9.0, but if any critical issues are found or if there's too little testing, we should postpone it.
Checklist