Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Running a server webpage link in COMPILING.md file #2419

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

jujudusud
Copy link
Member

@jujudusud jujudusud commented Feb 20, 2022

Short description of changes
Updating the following link from:
https://jamulus.io/wiki/Running-a-Server.md#command-line-options
to
https://jamulus.io/wiki/Running-a-Server#command-line-options

CHANGELOG: Update the link to "Running a server" web page.

Context: Fixes an issue?
Fixes: #2418

Does this change need documentation? What needs to be documented and how?
No changes requiered.

Status of this Pull Request
Ready to be merged.

What is missing until this pull request can be merged?
Nothing is missing.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@hoffie hoffie added this to the Release 3.9.0 milestone Feb 21, 2022
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new link works - thanks!

@hoffie hoffie requested a review from gilgongo February 21, 2022 00:05
@jujudusud
Copy link
Member Author

The new link works - thanks!

Ready to be merged in master as soon as it has been properly reviewed.

@gilgongo gilgongo merged commit d86b804 into jamulussoftware:master Feb 21, 2022
pgScorpio pushed a commit to pgScorpio/jamulus that referenced this pull request Mar 28, 2022
@ann0see
Copy link
Member

ann0see commented Jun 18, 2022

@jujudusud could you please add a CHANGELOG comment here?

@jujudusud
Copy link
Member Author

Is it ok like that @ann0see?

@ann0see
Copy link
Member

ann0see commented Jun 20, 2022

I'd add in COMPILING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated link to webpage in COMPILING.md
4 participants