Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Adjust Server Language combo box layout #2424

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented Feb 23, 2022

Short description of changes
Tiny change to style of language selection box in Server UI.

Context: Fixes an issue?
Before (Windows)
image

After (Linux, KDE, can't remember the widget set)
image

Does this change need documentation? What needs to be documented and how?
Screen shot update, maybe - not critical.

Status of this Pull Request
Complete.

What is missing until this pull request can be merged?
2 approvals.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones requested review from ann0see and hoffie February 23, 2022 11:14
@pljones pljones added this to the Release 3.9.0 milestone Feb 23, 2022
@hoffie hoffie added the needs documentation PRs requiring documentation changes or additions label Feb 23, 2022
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ann0see ann0see merged commit 7a5ae88 into jamulussoftware:master Feb 23, 2022
@ann0see
Copy link
Member

ann0see commented Feb 23, 2022

@gilgongo I think we can just copy the images from this PR?

@ann0see
Copy link
Member

ann0see commented Feb 23, 2022

CHANGELOG: UI: Adjust Server Language combo box length to fit into layout properly

@pljones pljones deleted the patch/language-selection branch February 23, 2022 15:10
@gilgongo gilgongo removed the needs documentation PRs requiring documentation changes or additions label Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants