Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian folder to gitignore #2464

Merged

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Mar 5, 2022

Short description of changes
Until now a debian folder might have been commited to git.

I remember thinking of this some time ago where it didn't work as expected. However now I can verify that the debian/ folder is no longer added to git. I hope it doesn't have any side-effects I can't remember.

CHANGELOG: Internal: Add debian/ folder to .gitignore file to ensure build files are not added to git

Context: Fixes an issue?
Often while developing locally, I had to manually choose the files & changes I made. Now a git add . should be enough

Does this change need documentation? What needs to be documented and how?
No.

Status of this Pull Request
Works locally, should have another review

What is missing until this pull request can be merged?
Review

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Until now a debian folder might have been commited to git.

I remember thinking of this some time ago where it didn't work as expected. However now I can verify that the debian/ folder is no longer added to git.
@ann0see ann0see merged commit 84084d7 into jamulussoftware:master Mar 6, 2022
@ann0see ann0see deleted the feature/addDebianFolderGitignore branch March 6, 2022 13:04
@pljones pljones added this to the Release 3.9.0 milestone Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants