-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autobuild: Reduce Qt download size & bump aqtinstall to 2.0.6 #2498
Conversation
2179a74
to
2e4c9a4
Compare
2e4c9a4
to
c716b3f
Compare
Anything specific to look for? Missing translations? Missing multi-threading support? |
Windows ASIO build works same with server (tested audio and translation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless macOS shows any errors (which I can't test at the moment since my VM doesn't start up) I think it's OK. Do we need more tests
Also tested both macOS clients and they worked (audio via black hole) |
Hmm, some missing modules cause failures (e.g. macextras), but other's don't (winextras, qttranslations): This PR essentially does what you did for Android here: (Except that we've never specified dependencies at all which made us download everything) I'm not sure if or what for It's hard to say what to look for. The still listed Qt archives are those which are not dropped (nothing to check as there's no change). The more interesting part is seeing whether any other archive might be needed and might fail silently. At the same time, if it does break something, Android has probably been broken since #2394 anyway. ;) This is the full list for Mac: I think the most valuable testing is the generic "3.9.0 beta" phase. |
Interesting side fact: I can rename d3dcompiler_47.dll libEGL.dll libGLESv2.dll and Jamulus still starts without error. To me this seems as if we can remove OpenGL on Windows. |
What artifact did you use for this test -- this PR or very recent master? |
Good question. I'll retry with the current master. |
Yes, the build from master still has these files. |
Hmm, I've no idea what adds them. When manually running the relevant |
Short description of changes
Autobuild: Bump aqtinstall to 2.0.6
Autobuild: Add proper quoting around aqt invocations
Autobuild: Download required Qt archives only
Autobuild: Shorten aqt install-qt invocation on Windows
CHANGELOG: Autobuild: Reduced Qt download size and updated aqtinstall to 2.0.6
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Ready.
What is missing until this pull request can be merged?
I believe that all possible errors which might be introduced by this change should either show up during build or during binary launch.
Checklist