Include ASIO details in Windows ASIO version #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
reviewed
Apr 23, 2022
| @@ -415,6 +415,11 @@ CAboutDlg::CAboutDlg ( QWidget* parent ) : CBaseDlg ( parent ) | |||
| ", <i><a href=\"https://www.qt.io\">https://www.qt.io</a></i></p>" | |||
| "<p>Opus Interactive Audio Codec" | |||
| ", <i><a href=\"https://www.opus-codec.org\">https://www.opus-codec.org</a></i></p>" | |||
| # if defined( _WIN32 ) && !defined( WITH_JACK ) | |||
There was a problem hiding this comment.
Hmm. Although not related, I think we should hava a "WITH_ASIO" default compile parameter instead of checking WITH_JACK everywhere...
There was a problem hiding this comment.
Perhaps introduce the "WITH_ASIO" as part of audio redesign? Current reasoning is that the ASIO is just the default and therefore no need to define. Thinking if there will be a "no sound" option, it might help to add a "WITH_ASIO" define.
hoffie
reviewed
May 21, 2022
There was a problem hiding this comment.
Thanks, code looks good. I've also tested the installer start pages via wine.
@henkdegroot Could you please rebase to resolve the conflict?
Minor inline comment whitespace nit.
henkdegroot
force-pushed
the
asio_agreement
branch
from
49fa63e to
19a0895
Compare
pljones
approved these changes
May 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Add ASIO logo and text to Windows Installer
Add ASIO reference to the About - Libraries page
Add ASIO reference to the CLI version output
All is only shown when the "default/ASIO" version is used.
CHANGELOG: Client: Include ASIO references in Windows ASIO version
Context: Fixes an issue?
Related: #2417
Does this change need documentation? What needs to be documented and how?
No
Screenshots
Installer Welcome Page:
About Screen:
Status of this Pull Request
Completed
What is missing until this pull request can be merged?
Review
Checklist