Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wrong occurances of "URL" #2608

Merged
merged 1 commit into from
May 2, 2022
Merged

Remove wrong occurances of "URL" #2608

merged 1 commit into from
May 2, 2022

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Apr 23, 2022 •
edited by hoffie
Loading

Short description of changes

CHANGELOG: Refactoring: Removed wrongly mentioned "URL" from help texts.

Context: Fixes an issue?

Fixes: #2332

Does this change need documentation? What needs to be documented and how?

No. Just translation

Status of this Pull Request

Ready for review.

What is missing until this pull request can be merged?

Nothing.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want (see CI and local test)
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@ann0see ann0see added this to the Release 3.9.0 milestone Apr 23, 2022
@ann0see ann0see added the refactoring Non-behavioural changes, Code cleanup label Apr 23, 2022
@hoffie hoffie requested a review from gilgongo April 26, 2022 19:52
@ann0see
Copy link
Member Author

ann0see commented May 2, 2022 •
edited
Loading

@ignotus666 since you're a translator, could you please review this? (should be trivial)

ignotus666
ignotus666 approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@ignotus666 ignotus666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

@ann0see
Copy link
Member Author

ann0see commented May 2, 2022

Great! Thanks.
@hoffie @gilgongo I'll merge this then.

@ann0see ann0see merged commit b5eb74d into jamulussoftware:master May 2, 2022
@ann0see ann0see deleted the patch/updateURL branch May 2, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignotus666 ignotus666 ignotus666 approved these changes

@hoffie hoffie hoffie approved these changes

@gilgongo gilgongo Awaiting requested review from gilgongo

Assignees
No one assigned
Labels
refactoring Non-behavioural changes, Code cleanup
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Update "URL" to domain in connectdlg.cpp
3 participants
@ann0see @hoffie @ignotus666