-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2628 Move CHighPrecisionTimer to util #2637
#2628 Move CHighPrecisionTimer to util #2637
Conversation
a84ab11
to
5851654
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing really but I'd wait until after 3.9.0, as moving to util might not be its final resting place.
I've just tagged it for 3.9.1 based on this.
In general I'd say it should go into 3.9.0 if it is ready. We can always change it later. Otherwise, such a PR is prone to be a target for conflicts which might be annoying to resolve.
Also, 3.9.0 is currently in a state with lots of moving parts under the hood, so it should get proper "generic" testing anyway.
f3e879f
to
08bceb8
Compare
08bceb8
to
40a14a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we're moving a lot of files around, I think we can merge this...
I agree with @pgScorpio that the util file gets filled with a lot of stuff...
40a14a3
to
4682a93
Compare
Well, a lot of it seems to be translations - I'm not sure how they get managed so I just bundled them in as they seemed to have changed. Merging. |
I should have changed the milestone when merging... |
Short description of changes
Removes dependency of Linux sound code on Server code by moving High Precision Timer to join the other timer code in Util.
CHANGELOG: Internal: code restructuring to reduce cross-dependencies (CHighPrecisionTimer)
Context: Fixes an issue?
Fixes: #2628
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Running on all my clients and servers.
What is missing until this pull request can be merged?
Nothing really but I'd wait until after 3.9.0, as moving to util might not be its final resting place.
Checklist