Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2628 Move CHighPrecisionTimer to util #2637

Merged

Conversation

pljones
Copy link
Collaborator

@pljones pljones commented May 22, 2022

Short description of changes

Removes dependency of Linux sound code on Server code by moving High Precision Timer to join the other timer code in Util.

CHANGELOG: Internal: code restructuring to reduce cross-dependencies (CHighPrecisionTimer)

Context: Fixes an issue?
Fixes: #2628

Does this change need documentation? What needs to be documented and how?
No.

Status of this Pull Request
Running on all my clients and servers.

What is missing until this pull request can be merged?
Nothing really but I'd wait until after 3.9.0, as moving to util might not be its final resting place.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

@pljones pljones force-pushed the patch/move-high-precision-timer branch from a84ab11 to 5851654 Compare May 22, 2022 08:57
@hoffie hoffie added this to the Release 3.9.0 milestone May 22, 2022
@hoffie hoffie linked an issue May 22, 2022 that may be closed by this pull request
@hoffie hoffie modified the milestones: Release 3.9.0, Release 3.9.1 May 22, 2022
Copy link
Member

@hoffie hoffie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing really but I'd wait until after 3.9.0, as moving to util might not be its final resting place.

I've just tagged it for 3.9.1 based on this.
In general I'd say it should go into 3.9.0 if it is ready. We can always change it later. Otherwise, such a PR is prone to be a target for conflicts which might be annoying to resolve.
Also, 3.9.0 is currently in a state with lots of moving parts under the hood, so it should get proper "generic" testing anyway.

src/sound/jack/sound.h Outdated Show resolved Hide resolved
src/util.h Outdated Show resolved Hide resolved
@pljones pljones force-pushed the patch/move-high-precision-timer branch 3 times, most recently from f3e879f to 08bceb8 Compare May 23, 2022 06:13
@pljones pljones force-pushed the patch/move-high-precision-timer branch from 08bceb8 to 40a14a3 Compare May 26, 2022 06:12
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we're moving a lot of files around, I think we can merge this...

I agree with @pgScorpio that the util file gets filled with a lot of stuff...

@pljones pljones force-pushed the patch/move-high-precision-timer branch from 40a14a3 to 4682a93 Compare May 28, 2022 16:17
@pljones
Copy link
Collaborator Author

pljones commented May 28, 2022

As we're moving a lot of files around, I think we can merge this...

Well, a lot of it seems to be translations - I'm not sure how they get managed so I just bundled them in as they seemed to have changed.

Merging.

@pljones pljones merged commit 7048e6e into jamulussoftware:master May 28, 2022
@pljones pljones deleted the patch/move-high-precision-timer branch May 28, 2022 16:20
@pljones pljones modified the milestones: Release 3.9.1, Release 3.9.0 Jun 18, 2022
@pljones
Copy link
Collaborator Author

pljones commented Jun 18, 2022

I should have changed the milestone when merging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

linux/sound.h should not depend on src/server.h
3 participants