Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autobuild: Make release changelog generation explicit #2655

Closed

Conversation

hoffie
Copy link
Member

@hoffie hoffie commented Jun 18, 2022

Short description of changes

  • Autobuild: Use a variable instead of hardcoding the release changelog path twice

  • Autobuild: Make release changelog generation explicit
    This was previously done as part of the variable extraction step.
    It's rather surprising to have a script with the name "analyze*" write
    to some Changelog file.

    Therefore, move all of the generation to the same abstraction level (Github workflow).

CHANGELOG: (List along with the other autobuild improvements)

Context: Fixes an issue?
Fixes #2480

Does this change need documentation? What needs to be documented and how?
No.

Status of this Pull Request
Tested on my repo: https://github.com/hoffie/jamulus/runs/6948860313?check_suite_focus=true#step:5:1

What is missing until this pull request can be merged?
Reviews.

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

hoffie added 2 commits June 18, 2022 16:42
This was previously done as part of the variable extraction step.
It's rather surprising to have a script with the name "analyze*" write
to some Changelog file.

Therefore, move all of the generation to the same abstraction level
(Github workflow).

Fixes jamulussoftware#2480
@hoffie hoffie added this to the Release 3.9.0 milestone Jun 18, 2022
@hoffie
Copy link
Member Author

hoffie commented Jun 18, 2022

Meh, this was supposed to be fixed in #2584 already. Somehow it's missing most of the mentioned commits. I will try to re-submit a fixed up #2584 instead.

@hoffie hoffie closed this Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autobuild: Make Changelog generation an extra step
2 participants