Update fr_FR app translation for 3.9.0

[jujudusud]

Short description of changes

Updating the fr_FR application translation for 3.9.0 version.

CHANGELOG: Update fr_FR app translation for 3.9.0

Context: Fixes an issue?

Fixes #2694

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

To be merged before 3.9.0 release

What is missing until this pull request can be merged?

• Waiting for a review

Checklist

• I've verified that this Pull Request follows the general code principles
• I tested my code and it does what I want
• My code follows the style guide
• I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
• I've filled all the content above

[ann0see]

@jujudusud
First of all thanks for the speed ;-).

Why is this PR set to draft? Do you still plan to change something?

[jujudusud]

Why is this PR set to draft? Do you still plan to change something?

No, nothing. I will turn it to ready for review.

[pljones]

Thanks! Great to get so much more of the French translation done. Just the big thing of sticking to annuaire for Directory through out. If you could check all the existing translations, too, to remove serveur for Directory translations (whether or not Custom), that'd be really great! :)

[pljones]

Mm, here the UI label in English is Directory. I've not checked the French but la liste déroulante Annuaires would then need to use the singlular.

(edit: Ah, it's filename="../connectdlgbase.ui" line="35, Annuaire, so yes, it needs to match here.)

(And yes, we could do with a tool that makes this kind of cross-referencing ... not a problem.)

[pljones]

Brilliant, thanks for that - just caught a couple more.

[pljones]

Looks like something went wrong. You've got a pull request against somewhere that's causing a later change to be shown in the diff.

Can you do:

• git status
  (check you've no pending changes)
• git checkout master
  (in case you weren't there)
• git pull upstream master
  (to get the latest changes in your repo)
• git checkout translate-r3_9_0-french
  (to get back to your branch)
• git rebase -i master
  (this should list only one commit - the one containing your translations; delete anything spurious, leaving just that one; if that goes wrong... shout for help)
• git diff master
  (this should show only your changes - if there are any others, again, shout for help)
• git push --force
  (to get your updated local change into your github repo, replacing what's there)

If you had the "clean" commit (where git diff SOMEMASTERCOMMIT..SOMELOSTCOMMIT shows exactly what you expect), you could use git reset --hard to move the HEAD of your branch to that point, and then rebase again from there to see if it cleans things up.

[jujudusud]

Hum, I'm already stuck with the parse error. I will try to reset.

[ann0see]

• Translator listed in the src/util.cpp
• Punctuation and spacing consistent
• Signal words consistent ("ASIO", "Buffer")
• No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLTION*.ts) (not checked)
• Only a single .ts file checked in (+ Installer translations)

[ann0see]

Ok. @jujudusud i seems as if the following isn't finished yet:

        <translation>Démarrage minimisé au lancement du système d&apos;exploitation</translation>
    </message>
    <message>
        <location filename="../serverdlg.cpp" line="737"/>
        <source>Now a directory</source>
        <translation type="unfinished"></translation>
    </message>
    <message>
        <source>Make My Server Public</source>
        <translation type="vanished">Rendre mon serveur public</translation>
    </message>
--
        <translation>Inscrit</translation>
    </message>
    <message>
        <location filename="../util.h" line="648"/>
        <source>Directory server list full</source>
        <translation type="unfinished"></translation>
    </message>
    <message>
        <source>Directory Server full</source>
        <translation type="vanished">Serveur annuaire plein</translation>
    </message>

I think there's an issue with the Now a directory line.

[ann0see]

Could you please download and check if the app shows the Now a directory correctly and if it's duplicated?

[trebmuh]

Sorry @jujudusud , I probably won't have time to review this PR because this month is the busiest month of the year in my daily job. See you next time then! 😎

[jujudusud]

This last commit is a squash merge of the four precedent commits.

[pljones]

Looks okay to me now.

[ann0see]

Finally did the last check. Thanks and sorry for the delay