Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPILING.md: Add table for compile time arguments #2707

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

ann0see
Copy link
Member

@ann0see ann0see commented Jul 4, 2022

Short description of changes

Add a list for supported compile time optimistic COMPILING.md. This especially documents the nojsonrpc build option

CHANGELOG: Documentation: Document compile time options to COMPILING.md

Context: Fixes an issue?

No. however this removes the needs documentation label of #2660 (I don’t think we habe anything related to the compilation of the server on the website anymore)

Does this change need documentation? What needs to be documented and how?
No. It is documentation 😀

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged?

Review by @gilgongo or @pljones

Checklist

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

COMPILING.md Outdated Show resolved Hide resolved
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
@hoffie hoffie added this to the Release 3.9.0 milestone Jul 5, 2022
@hoffie hoffie changed the title Add table for compile time arguments COMPILING.md: Add table for compile time arguments Jul 5, 2022
@ann0see ann0see merged commit 6744342 into jamulussoftware:master Jul 6, 2022
@ann0see ann0see deleted the doc/addCompileTimeArgs branch July 6, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants