Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update translation_zh_CN.ts #2719

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Update translation_zh_CN.ts #2719

merged 1 commit into from
Jul 12, 2022

Conversation

BLumia
Copy link
Contributor

@BLumia BLumia commented Jul 9, 2022

Resolve GH-2702

@pljones
Copy link
Collaborator

pljones commented Jul 9, 2022

Thanks for this (and especially for spotting the "Now a directory server" error in the English). Is there anyone you know who could review it here (on Github)?

@ann0see ann0see added this to the Release 3.9.0 milestone Jul 9, 2022
ann0see
ann0see reviewed Jul 9, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks consistent, I doubt we have any chinese reviewer?

@ann0see
Copy link
Member

ann0see commented Jul 9, 2022 •
edited
Loading

  • Translator listed in the src/util.cpp
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLTION*.ts) (todo)
  • Only a single .ts file checked in (+ Installer translations)

@pljones pljones added the translation used by tools/create-translation-issues.sh label Jul 11, 2022
ann0see
ann0see approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't check the Chinese, but it seems ok. Thanks!

pljones
pljones approved these changes Jul 12, 2022
View reviewed changes
Copy link
Collaborator

@pljones pljones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved without understanding. :)

@pljones pljones merged commit 7622f16 into jamulussoftware:master Jul 12, 2022
@BLumia BLumia deleted the translation-2702 branch July 13, 2022 01:05
@pljones pljones mentioned this pull request Jul 22, 2022
Closed
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ann0see ann0see ann0see approved these changes

@pljones pljones pljones approved these changes

Assignees
No one assigned
Labels
translation used by tools/create-translation-issues.sh
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Update zh_CN app translation for 3.9.0
3 participants
@BLumia @pljones @ann0see