Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pt_BR app translation for r3.9.0 #2728

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Update pt_BR app translation for r3.9.0 #2728

merged 5 commits into from
Jul 22, 2022

Conversation

melcon
Copy link
Contributor

@melcon melcon commented Jul 11, 2022

Fixes #2698

@pljones
Copy link
Collaborator

pljones commented Jul 11, 2022

Just the one fix needed.

@pljones pljones added this to the Release 3.9.0 milestone Jul 11, 2022
@pljones pljones added the translation used by tools/create-translation-issues.sh label Jul 11, 2022
@ann0see
Copy link
Member

ann0see commented Jul 16, 2022

@melcon any updated here?

@ann0see
Copy link
Member

ann0see commented Jul 17, 2022 •
edited
Loading

Also pasting the review checklist here. Please check as appropriate

  • Translator listed in the src/util.cpp

    jamulus/src/util.cpp

    Line 705 in fa204ad

    "<p>Melcon Moraes (<a href=\"https://github.com/melcon\">melcon</a>)</p>"
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • App translations: No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLATION*.ts)
  • App translations: Only a single .ts file checked in (.qm in addition is also OK)

@melcon
Update pt_BR app translation for r3.9.0
6c96337 
Fixed typo, capitalization, missed space and missed translation.
ann0see
ann0see approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok thanks. The windows ASIO build failed. Probably Steinberg has issues.

@melcon
Update pt_BR app translation for r3.9.0
ed6e148 
Fixed more typos, capitalization and missed space.
@melcon melcon requested a review from pljones July 19, 2022 11:52
@melcon
Update pt_BR app translation for r3.9.0
57cf43b 
Fixed the translation for jamulussoftware#2710 that got messed up during the branching/fetch/merge. This is the last one for pt_BR
@melcon melcon changed the title App translate pt_br r3.9.0 Update pt_BR app translation pt_br for r3.9.0 Jul 22, 2022
@melcon melcon changed the title Update pt_BR app translation pt_br for r3.9.0 Update pt_BR app translation for r3.9.0 Jul 22, 2022
@pljones pljones merged commit baef2d8 into jamulussoftware:master Jul 22, 2022
@pljones pljones mentioned this pull request Jul 22, 2022
Closed
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ann0see ann0see ann0see approved these changes

@pljones pljones pljones approved these changes

Assignees
No one assigned
Labels
translation used by tools/create-translation-issues.sh
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Update pt_BR app translation for 3.9.0
3 participants
@melcon @pljones @ann0see