-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pl_PL app translation for 3.9.0 #2735
Update pl_PL app translation for 3.9.0 #2735
Conversation
Thanks! Do we have anyone who can review this? |
Review Checklist:
|
@SeeLook this also needs to be rebased to fix the conflicts: https://github.com/jamulussoftware/jamulus/blob/master/docs/TRANSLATING.md#updating-a-prfixing-conflicts |
f43f363
to
95fe105
Compare
src/translation/translation_pl_PL.ts
Outdated
@@ -2576,12 +2576,12 @@ Twój kanał został wyciszony i włączono „Wycisz mnie”. Napraw przyczynę | |||
<message> | |||
<location filename="../connectdlg.cpp" line="87"/> | |||
<source>If you know the server address, you can connect to it using the Server name/Address field. An optional port number can be added after the server address using a colon as a separator, e.g. %1. The field will also show a list of the most recently used server addresses.</source> | |||
<translation type="unfinished"></translation> | |||
<translation>Jeżeli znasz adres adres serwera możesz podłączyć się do niego podając te dane w polu nazwa/adres serwera. Dodatkowo może być podany numer portu - po dwukropku za adresem/numerem IP, np. %1. To pole tekstowe będzie także wyświetlać listę ostatnio używanych adresów.</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jeżeli znasz adres adres serwera możesz podłączyć
-- adres
is duplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
</message> | ||
<message> | ||
<location filename="../serverdlg.cpp" line="195"/> | ||
<source>Custom Directory address</source> | ||
<translation type="unfinished"></translation> | ||
<translation>Własny adres serwera zbiorczego</translation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The English doesn't contain the word "server", so this is wrong.
Please read up on the explanation around Client, Server and Directory usage within the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can translate English word 'Directory' directly into Polish but this is very general, technical and says nothing about.
So I used Polish „Serwer zbiorczy” which describes 'Directory' more precise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's meant to mean the same as "address book", like where you'd keep names and addresses. Nothing technical about it.
@pljones would you be ok with a merge of this PR despite the open comment? |
I'll leave it for today. If @SeeLook can fix the various references by tomorrow, we can merge. I'd rather get them consistent. |
Fixes #2697
Short description of changes
CHANGELOG:
Context: Fixes an issue?
Does this change need documentation? What needs to be documented and how?
Status of this Pull Request
What is missing until this pull request can be merged?
Checklist