Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update it_IT app translation for 3.9.0 #2695 #2739

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Update it_IT app translation for 3.9.0 #2695 #2739

merged 1 commit into from
Jul 22, 2022

Conversation

dzpex
Copy link
Contributor

@dzpex dzpex commented Jul 18, 2022 •
edited by ann0see
Loading

Short description of changes
Update it_IT app translation for 3.9.0

CHANGELOG: Updated Italian translation of app for 3.9.0

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

ann0see
ann0see approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@ann0see ann0see left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly scanned, should be good. Thanks

@ann0see
Copy link
Member

ann0see commented Jul 22, 2022 •
edited
Loading

Review Checklist:

  • Translator listed in the src/util.cpp
  • Punctuation and spacing consistent
  • Signal words consistent ("ASIO", "Buffer")
  • App translations: No untranslated strings (grep unfinished -5 src/translation/translation_$TRANSLATION*.ts)
  • App translations: Only a single .ts file checked in (.qm in addition is also OK)

@ann0see ann0see force-pushed the master branch 2 times, most recently from aeb4a24 to adeccaa Compare July 22, 2022 18:33
@ann0see
Copy link
Member

ann0see commented Jul 22, 2022

Ok. Just changed the commit message, rebased and added the new .qm file. It should be good to go now.

@ann0see ann0see added this to the Release 3.9.0 milestone Jul 22, 2022
@ann0see ann0see requested a review from pljones July 22, 2022 19:10
@pljones pljones linked an issue Jul 22, 2022 that may be closed by this pull request
Update it_IT app translation for 3.9.0 #2695
Closed
@pljones pljones merged commit 1f18d6c into jamulussoftware:master Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ann0see ann0see ann0see approved these changes

@pljones pljones pljones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release 3.9.0
Development

Successfully merging this pull request may close these issues.

Update it_IT app translation for 3.9.0
3 participants
@dzpex @ann0see @pljones