Bugfix/#2723 self label checkboxes #2996

pljones · 2023-01-21T10:42:36Z

Short description of changes

UI/UX issue #2723 requests that all check boxes be made "self-labelling". This makes the change to the relevant forms.

(It also causes the Server UI to start on "Server Setup" rather than "Options" consistently.)

CHANGELOG: GUI: Make checkboxes self-labelling

Context: Fixes an issue?

Fixes: #2723

Does this change need documentation? What needs to be documented and how?

Yes, User Manual and Server Manual screen shot updates are needed. This affects translations.

Status of this Pull Request

Needs review.
Depends on:

bugfix/remove-remaining-directory-server-mentions
bugfix/rpc-remaining-directory-server-mentions

What is missing until this pull request can be merged?

Needs review.

Checklist

I've verified that this Pull Request follows the general code principles
I tested my code and it does what I want
My code follows the style guide
I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
I've filled all the content above

ann0see

Thanks. Will try if I have time.

src/clientsettingsdlgbase.ui

pljones · 2023-01-21T13:48:40Z

Thanks. Will try if I have time.

Thanks.

pljones · 2023-01-21T14:16:20Z

The "My Profile" tab allows the user to adjust the width of the window.

On Windows (GitHub build), using the drop down doesn't set itself to the correct width -- and I've no idea why.

The window shrinks width-ways too much

When it's stretching width-ways, some of the labels become unaligned - I did have a version with this fixed but I lost it somehow.
Aligned:

Unaligned:
Windows:
Linux seems somewhat more prone to it (probably a skin-dependent issue as to how much it happens):

ann0see · 2023-01-21T19:26:54Z

The window shrinks width-ways too much

Not a regression I think. Someone requested it a while ago. But not sure why.

ann0see · 2023-01-21T19:48:23Z

I think that's ok?

pljones · 2023-01-22T09:07:44Z

The window shrinks width-ways too much

Not a regression I think. Someone requested it a while ago. But not sure why.

Yeah - the "form" version stopped it but broke the layout in other ways (i.e. stretch all fields equally).

src/serverdlg.cpp

src/translation/translation_de_DE.ts

src/translation/translation_fr_FR.ts

pljones · 2023-04-05T09:34:50Z

I've got a new version of https://github.com/pljones/jamulus/tree/bugfix/%232723-self-label-checkboxes-forms2 available here:
https://github.com/pljones/jamulus/actions/runs/4616999421

The Windows version still has this annoying display error:

The window needs stretching about six pixels wider to get the dropdown to display correctly. I'd rather it "naturally" found the right width, as different font sizes (i.e. themes) may have different needs -- so I was wondering if this is a Qt 5 bug.

Can anyone - @jamulussoftware/maindevelopers particularly - take a look?

Also, @ann0see, @gilgongo or @emlynmac, could you check that build on a Mac, please. If it's okay (this is the Client Settings Dialog and Server Dialog changes) - including when resizing, please confirm here. I'll rebase and make it https://github.com/pljones/jamulus/tree/bugfix/%232723-self-label-checkboxes if it's okay, then we can progress this (once the directory changes are merged).

pljones · 2023-04-17T19:58:13Z

In addition to the build here:

forms1 version: https://github.com/pljones/jamulus/actions/runs/4725240278
forms2 version: https://github.com/pljones/jamulus/actions/runs/4725241301

I could do with MacOS people checking both to see whether they work (profile, maximize window). I'd prefer to go with forms2.

(Of course, immediately outdated...)

gilgongo · 2023-04-18T18:48:27Z

In addition to the build here:

forms1 version: https://github.com/pljones/jamulus/actions/runs/4725240278

forms2 version: https://github.com/pljones/jamulus/actions/runs/4725241301

Just tried forms2 on Monterey 12.6.1 and it seems OK to me (profile, maximize window)

gilgongo · 2023-04-19T21:32:20Z

Ah OK. BTW "Mixer Rows" would be nicer at about 25% of the length it is in that screenshot, but it's not a big problem.

pljones · 2023-04-20T16:35:30Z

No, that's not the intended layout. That's why it was important to test on macOS explicitly as Linux and Windows do not show that behaviour.

Note, the request to check "maximize" applied to all settings tabs.

Four "important" files change here --

src/clientsettingsdlg.cpp and src/clientsettingsdlgbase.ui
controlling the client settings UI. No other UI changes or code touched in the client but all three settings tabs affected.
src/serverdlg.cpp and src/serverdlgbase.ui
controlling the server UI (no other server changes).

So those areas could do with review for rendering style on all platforms (ideally old versus new, various screen resolutions and layouts).

pljones · 2023-04-21T20:23:07Z

OK, reverted the one with the macOS breakage.

ann0see · 2023-04-26T20:35:45Z

So @pljones do you think the macOS build is ok with your latest changes?

pljones · 2023-04-27T18:51:30Z

So @pljones do you think the macOS build is ok with your latest changes?

I've not had time over the last few days to keep up. Hopefully the current build on this branch is okay again.

ann0see · 2023-05-31T19:18:43Z

I will - hopefully - have access to a real Mac in the next weeks but no guarantees.

pljones · 2023-06-02T20:24:31Z

OK, it builds and runs on Linux (6.5.1). One tiny glitch (likely 6.5.1 related) - opening settings, the "My Profile" tab didn't show until I switched tabs. Very odd...

pljones · 2023-06-03T08:55:15Z

OK, it builds and runs on Linux (6.5.1). One tiny glitch (likely 6.5.1 related) - opening settings, the "My Profile" tab didn't show until I switched tabs. Very odd...

Confirmed on main -
Check settings:

No "My Profile tab"

Switch to "Advanced Setup" and it appears:

Once it's appeared, it stays for the duration of the run. Checking the checkbox multiple times doesn't fix it. Using the "Settings" menu to go straight to "My Profile" or using Ctrl-P both work okay.

So that'll need picking up under the move to Qt6.5.1...

And confirmed Qt5.15.2 doesn't show the strangeness.

I'm beginning to think Qt6 isn't ready for prime time.

ann0see · 2023-06-03T20:11:29Z

This is the current artifact from this PR - and I believe it's ok.

ann0see · 2023-06-03T20:14:25Z

src/serverdlg.cpp

+    // always start on the main tab
+    tabWidget->setCurrentIndex ( 0 );
+
    // set window title


Does the Qt 6.5 bug also occur if this isn't set?

That's src/serverdlg.cpp, not related to the client settings "My Profile" weirdness.

Uh. Yes. It's a different file - so that's true.

ann0see

Approving on the basis that this works on the CURRENT Qt version.

pljones · 2023-06-04T12:34:47Z

Merging - we can pick up any reported problems later. Hopefully it'll be okay.

ann0see · 2023-07-24T20:35:52Z

@pljones does this still need documentation? If no, please drop the needs documentation label.

ann0see reviewed Jan 21, 2023

View reviewed changes

src/clientsettingsdlgbase.ui Show resolved Hide resolved

mcfnord reviewed Jan 22, 2023

View reviewed changes

src/serverdlg.cpp Outdated Show resolved Hide resolved

mcfnord reviewed Jan 22, 2023

View reviewed changes

src/translation/translation_de_DE.ts Show resolved Hide resolved

mcfnord reviewed Jan 22, 2023

View reviewed changes

src/translation/translation_de_DE.ts Show resolved Hide resolved

mcfnord reviewed Jan 22, 2023

View reviewed changes

src/translation/translation_fr_FR.ts Show resolved Hide resolved

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch from f5aecbf to 3d2b392 Compare February 17, 2023 18:48

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch 2 times, most recently from 213fe51 to d47e94c Compare February 26, 2023 17:51

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch 4 times, most recently from 305fc49 to 97032d7 Compare April 1, 2023 14:12

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch 2 times, most recently from f7572ce to 2b8c51b Compare April 13, 2023 17:27

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch 2 times, most recently from bff052a to 6c20966 Compare April 17, 2023 19:51

pljones self-assigned this Apr 17, 2023

pljones added the needs documentation PRs requiring documentation changes or additions label Apr 17, 2023

pljones added this to the Release 3.10.0 milestone Apr 17, 2023

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch from 6c20966 to b5445d1 Compare April 17, 2023 20:08

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch from 6fa64cd to b5445d1 Compare April 21, 2023 20:22

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch from b5445d1 to b39f93a Compare April 23, 2023 08:52

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch 2 times, most recently from f5d4591 to 78960f9 Compare May 1, 2023 16:03

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch from 78960f9 to 6d1172c Compare May 10, 2023 17:04

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch 3 times, most recently from 0ff51b6 to aee6bbe Compare May 22, 2023 18:41

pljones added 2 commits May 31, 2023 14:07

issue/2723 Controls should be "self-labelling"

ea1d49d

Add Qt Translation files

a0df8cd

pljones force-pushed the bugfix/#2723-self-label-checkboxes branch from aee6bbe to a0df8cd Compare May 31, 2023 13:08

ann0see reviewed Jun 3, 2023

View reviewed changes

ann0see approved these changes Jun 3, 2023

View reviewed changes

pljones merged commit d7465f5 into jamulussoftware:main Jun 4, 2023

pljones mentioned this pull request Jun 25, 2023

Bugfix/816 jamulus 2723 self-labelled checkboxes jamulussoftware/jamuluswebsite#931

Merged

7 tasks

pljones removed the needs documentation PRs requiring documentation changes or additions label Jul 25, 2023

gilgongo mentioned this pull request Aug 8, 2023

Prepare release 3.10.0 #3094

Closed

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfix/#2723 self label checkboxes #2996

Bugfix/#2723 self label checkboxes #2996

pljones commented Jan 21, 2023 •

edited by ann0see

Loading

ann0see left a comment

pljones commented Jan 21, 2023

pljones commented Jan 21, 2023

ann0see commented Jan 21, 2023

ann0see commented Jan 21, 2023

pljones commented Jan 22, 2023

pljones commented Apr 5, 2023

pljones commented Apr 17, 2023 •

edited

Loading

gilgongo commented Apr 18, 2023

gilgongo commented Apr 19, 2023

pljones commented Apr 20, 2023 •

edited

Loading

pljones commented Apr 21, 2023 •

edited

Loading

ann0see commented Apr 26, 2023

pljones commented Apr 27, 2023

ann0see commented May 31, 2023

pljones commented Jun 2, 2023 •

edited

Loading

pljones commented Jun 3, 2023 •

edited

Loading

ann0see commented Jun 3, 2023

ann0see Jun 3, 2023

pljones Jun 4, 2023

ann0see Jun 4, 2023

ann0see left a comment

pljones commented Jun 4, 2023

ann0see commented Jul 24, 2023

Bugfix/#2723 self label checkboxes #2996

Bugfix/#2723 self label checkboxes #2996

Conversation

pljones commented Jan 21, 2023 • edited by ann0see Loading

Checklist

ann0see left a comment

Choose a reason for hiding this comment

pljones commented Jan 21, 2023

pljones commented Jan 21, 2023

ann0see commented Jan 21, 2023

ann0see commented Jan 21, 2023

pljones commented Jan 22, 2023

pljones commented Apr 5, 2023

pljones commented Apr 17, 2023 • edited Loading

gilgongo commented Apr 18, 2023

gilgongo commented Apr 19, 2023

pljones commented Apr 20, 2023 • edited Loading

pljones commented Apr 21, 2023 • edited Loading

ann0see commented Apr 26, 2023

pljones commented Apr 27, 2023

ann0see commented May 31, 2023

pljones commented Jun 2, 2023 • edited Loading

pljones commented Jun 3, 2023 • edited Loading

ann0see commented Jun 3, 2023

ann0see Jun 3, 2023

Choose a reason for hiding this comment

pljones Jun 4, 2023

Choose a reason for hiding this comment

ann0see Jun 4, 2023

Choose a reason for hiding this comment

ann0see left a comment

Choose a reason for hiding this comment

pljones commented Jun 4, 2023

ann0see commented Jul 24, 2023

pljones commented Jan 21, 2023 •

edited by ann0see

Loading

pljones commented Apr 17, 2023 •

edited

Loading

pljones commented Apr 20, 2023 •

edited

Loading

pljones commented Apr 21, 2023 •

edited

Loading

pljones commented Jun 2, 2023 •

edited

Loading

pljones commented Jun 3, 2023 •

edited

Loading