Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bump jack from 1.9.21 to 1.9.22 (Automated PR) #3011

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

This automated Pull Request updates the used jack version to version 1.9.22.

This PR was opened by the workflow Bump dependencies (create-prs)

CHANGELOG: Build: Updated bundled JACK (Windows-only) to version 1.9.22

@hoffie hoffie force-pushed the ci/bump-dependencies/jack branch from 6802b3e to 6d78bc0 Compare February 14, 2023 17:29
@ann0see ann0see self-requested a review February 14, 2023 17:46
@ann0see
Copy link
Member

ann0see commented Feb 14, 2023

Ok. At least the PR gets opened.

@hoffie hoffie force-pushed the ci/bump-dependencies/jack branch 2 times, most recently from bfcfa52 to add0c4c Compare February 15, 2023 17:40
@pljones
Copy link
Collaborator

pljones commented Feb 15, 2023

Needs rebasing then rebuilding to get the clean Jack build?

@hoffie hoffie force-pushed the ci/bump-dependencies/jack branch from add0c4c to 761f713 Compare February 15, 2023 18:27
@ann0see
Copy link
Member

ann0see commented Feb 16, 2023

I think something else is wrong.

@pljones
Copy link
Collaborator

pljones commented Feb 16, 2023

https://downloads.sourceforge.net/project/nsis/NSIS%203/3.08/nsis-3.08.zip failed, trying again in 20s
WARNING: Caught error: Exception calling "GetResponse" with "0" argument(s): "The request was aborted: Could not create
 SSL/TLS secure channel."

... and then it doesn't find jack.h under C:\Program Files, either...

@hoffie hoffie force-pushed the ci/bump-dependencies/jack branch from 761f713 to 8f3964a Compare February 24, 2023 22:10
@ann0see
Copy link
Member

ann0see commented Feb 24, 2023

I hope this works now after some time. We might want to add some downloading retries somewhere?

@ann0see
Copy link
Member

ann0see commented Mar 6, 2023

Maybe jack now installs somewhere else?

@pljones
Copy link
Collaborator

pljones commented Mar 6, 2023

Maybe it could log more (like where it went looking for the installer and where the installer put the installation):

Downloading 64 Bit and 32 Bit JACK installer (if needed)...
Installing JACK2 64-bit...
64bit JACK installation completed successfully
Installing JACK2 32-bit...
32bit JACK installation completed successfully

@hoffie hoffie force-pushed the ci/bump-dependencies/jack branch from 8f3964a to e666506 Compare March 22, 2023 13:17
@hoffie hoffie force-pushed the ci/bump-dependencies/jack branch from e666506 to 1eab5b1 Compare March 22, 2023 13:32
ann0see added a commit to ann0see/jamulus that referenced this pull request Mar 22, 2023
@ann0see
Copy link
Member

ann0see commented Mar 22, 2023

Could it be that we have a permission error somewhere? My PR seems to get through.

@ann0see ann0see removed their request for review March 22, 2023 19:40
@ann0see ann0see closed this Mar 24, 2023
@github-actions github-actions bot deleted the ci/bump-dependencies/jack branch March 24, 2023 21:18
@ann0see
Copy link
Member

ann0see commented Mar 24, 2023

Closing as I now merged my PR. I think this might have failed due to some permission error. Let's wait and see what happens if there is another JACK update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants