-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3050 Save HTML formatting in Server Welcome Message #3058
#3050 Save HTML formatting in Server Welcome Message #3058
Conversation
53df82c
to
84b9542
Compare
@pljones, On the current build, on Debian 10 this error does only occur if I close and reopen twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, it works, but we should probably set the field to not support HTML formatting - or a way to toggle it.
(I didn't test the builds because I didn't know the builds were -- or if I had to build from source, which source?) |
I've just killed the build. This should give you access to the artifacts: https://github.com/jamulussoftware/jamulus/actions/runs/4939367648 (scroll down the page and you should be able to see the files) If you build from source, you'd need to clone the repository by pljones. then |
We're onto this, I hope?
|
Yes. See my PRs for iOS and macOS |
Ah right. |
41c4ac7
to
eb3d4b6
Compare
eb3d4b6
to
203f7c1
Compare
@pljones I think this is changelog worthy. |
Updated the top post. Does that do it? |
Yes. I think so |
Short description of changes
CHANGELOG: Server: Save the HTML formatting in Server Welcome Message. (Applies to the GUI Server.)
Context: Fixes an issue?
Fixes: 3050
Does this change need documentation? What needs to be documented and how?
No.
Status of this Pull Request
Tested locally.
What is missing until this pull request can be merged?
Could do with @kjcole testing one of the builds.
Checklist