-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Bump NSIS from 3.08 to 3.09 (Automated PR) #3097
Conversation
444d29e
to
59accbc
Compare
It would be nice if @github-actions posted a link to the change notice for the dependency update... |
Posting it here: https://sourceforge.net/projects/nsis/files/NSIS%203/3.09/ as reference.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Install over existing install, uninstall work with the ASIO version. Also a clean install works. So I think it's good to merge.
Edit: JACK version also installs fine.
59accbc
to
9e51119
Compare
Does any of that mean it's easier to convince Windows to have both ASIO and JACK installs side by side and treat them as separate? (Currently it gets confused.) |
No. Currently you can't install JACK and ASIO. |
You can. I do. I run them at the same time - JACK's ASIO input for one instance of Jamulus, ReaRoute to JACK to Jamulus on another JACK ASIO pair. It's just the installer gets confused when updating or uninstalling - presumably they share a registry key. |
Yes. They do share the same registry key and default installation directory. |
OK, I've opened #3103 for splitting the keys. |
9e51119
to
d74dc40
Compare
Thanks. Do you think this PR is ready? If yes, please merge it. |
This automated Pull Request updates the used NSIS version to version 3.09.
This PR was opened by the workflow Bump dependencies (create-prs)
CHANGELOG: Build: Updated Windows Installer base (NSIS) to version 3.09