Refactor macOS App Store upload #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pljones
reviewed
Aug 22, 2024
ann0see
force-pushed
the
refactor/macDeploy
branch
3 times, most recently
from
12e8b2e to
39823d3
Compare
ann0see
force-pushed
the
refactor/macDeploy
branch
from
39823d3 to
a740e2f
Compare
softins
reviewed
Aug 22, 2024
mac/deploy_mac.sh
Outdated
Comment on lines
183
to
184
| cp -a "${raw_path}/${client_target_name}.app" "${macapp_deploy_path}/${client_target_name}.app" | ||
| # cp -a "${deploy_path}/${server_target_name}.app" "${macapp_deploy_path}/${server_target_name}.app" |
There was a problem hiding this comment.
Is it correct that client uses raw_path but server uses deploy_path? Or should they both be the same?
I can see from line 110 above that one contains a copy of the other, but I'm not clear whether at this point they are still the same.
There was a problem hiding this comment.
No. That's an oversight from me.
pljones
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Subject to fixing https://github.com/jamulussoftware/jamulus/pull/3350/files#r1727831460 I'm okay with it.
ann0see
force-pushed
the
refactor/macDeploy
branch
from
a740e2f to
1371b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Part of a series of refactoring the macOS AppStore upload procedure. This PR includes mostly moving code around and decouples the app store upload from the normal signing process.
Not tested without the other changes, but it should be ok.
CHANGELOG: Refactoring: Decouple App Store upload from dmg build
Context: Fixes an issue?
Related to: #3348 - at least somewhat.
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for review. Especially the moving around between multiple folders is somewhat not so nice.
What is missing until this pull request can be merged?
Review
Checklist