#606 Persist state of recorder #608
Merged
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you think we need a ChangeLog entry for this small change? |
|
The general wording in the last one should have covered it. And I thought I'd done it. So... it's more of a fix, really. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"norecord" value of "1" stored in inifile when Enable recorder is not checked in GUI, else stored as "0".
If --norecord is passed, stored value is not read (hence recorder remains disabled).
If --norecord is not passed, stored value is read and passed to recorder.
Recorder amended only to log (apparent) change in state.
(Because CServer is running before its configuration has been fully determined, this means that the recorder will still start up enabled if --norecord, issuing its state message; if the inifile then sets it to norecord, it will issue a second message for the change in state.)